spec.patches on CR are pruned

[atoato88]

What happened:

Values of "spec.patches" in CR are pruned even if controller is set with declarative.WithObjectTransform(addon.ApplyPatches).

What you expected to happen:

"spec.patches" values aren't pruned.

How to reproduce it (as minimally and precisely as possible):

• I use guestbook-operator
• create Guestbook CR following:

  apiVersion: addons.example.org/v1alpha1
  kind: Guestbook
  metadata:
  name: guestbook-sample
  spec:
  patches:
  - apiVersion: apps/v1
  kind: Deployment
  metadata:
    name: frontend
  spec:
    template:
      spec:
        affinity:
          nodeAffinity:
            requiredDuringSchedulingIgnoredDuringExecution:
              nodeSelectorTerms:
              - matchExpressions:
                - key: kubernetes.io/hostname
                  operator: In
                  values:
                  - host001

• check this resource by kubectl get guestbooks.addons.example.org guestbook-sample -o yaml:

  apiVersion: addons.example.org/v1alpha1
  kind: Guestbook
  metadata:
  creationTimestamp: "2022-08-24T13:00:31Z"
  generation: 1
  name: guestbook-sample
  namespace: default
  resourceVersion: "33192"
  uid: ed8a9372-1cc0-4cf9-8e4e-9f61945372d8
  spec:
  patches:
  - {}

• values at "spec.patches[]" are pruned.

Anything else we need to know?: NONE

Environment:

• Kubernetes version (use kubectl version):

  $ k version
  WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
  Client Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.0", GitCommit:"4ce5a8954017644c5420bae81d72b09b735c21f0", GitTreeState:"clean", BuildDate:"2022-05-03T13:46:05Z", GoVersion:"go1.18.1", Compiler:"gc", Platform:"linux/amd64"}
  Kustomize Version: v4.5.4
  Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.0", GitCommit:"4ce5a8954017644c5420bae81d72b09b735c21f0", GitTreeState:"clean", BuildDate:"2022-05-19T15:39:43Z", GoVersion:"go1.18.1", Compiler:"gc", Platform:"linux/amd64"}

• OS (e.g: cat /etc/os-release):

  $ cat /etc/os-release 
  NAME="Ubuntu"
  VERSION="20.04.4 LTS (Focal Fossa)"
  ID=ubuntu
  ID_LIKE=debian
  PRETTY_NAME="Ubuntu 20.04.4 LTS"
  VERSION_ID="20.04"
  HOME_URL="https://www.ubuntu.com/"
  SUPPORT_URL="https://help.ubuntu.com/"
  BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
  PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
  VERSION_CODENAME=focal
  UBUNTU_CODENAME=focal

• Kernel (e.g. uname -a):

  5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

• Go version (e.g. go version):go version go1.17.11 linux/amd64
• Others:

[atoato88]

As of now, CRD version is v1, so we need some additional parameters for CRD manifest, by that, we preserve spec.pathes values, I guess. Maybe this issue is related. :thinking:

/assign

[atoato88]

Is it needed to add markers witten at this document?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[atoato88]

/close This issue related with #237 (already closed), but that PR is closed. So I close this issue.

[k8s-ci-robot]

@atoato88: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/issues/236#issuecomment-1386498105): >/close >This issue related with #237 (already closed), but that PR is closed. >So I close this issue. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.