More mock testing - Githubissues

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder

Apache License 2.0

254 stars 84 forks source link

More mock testing #242

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

Create some golden tests to try to make sure our apply library is reasonably efficient / so we can track what it is doing.

tests: Improve mock kubeapiserver, introduce test for direct Applier
tests: record and validate the requests we are making
tests: add test for when objects already exist
tests: add test for the case when last-applied is present

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

justinsb commented 1 year ago

Most of the lines of code are from https://github.com/kubernetes/kops/tree/master/pkg/applylib/mocks/mockkubeapiserver ... I'm trying "copy and paste" reuse until we figure out where it should live. But maybe it should just live here, so maybe I should give it its own go.mod here...

cheftako commented 1 year ago

/lgtm Couple of minor questions but on the whole looks good.