search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
254 stars 84 forks source link

Direct applier: Avoid fetching OpenAPI #247

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

We don't normally need it, and it is expensive to fetch. Use ApplyOptions directly rather than going through the kubectl abstraction layer (which always fetches the OpenAPI)

Builds on #246

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
justinsb commented 1 year ago

/test pull-declarative-test

Known flakiness, addressed in #247

johnsonj commented 1 year ago

/lgtm