Closed justinsb closed 1 year ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: justinsb
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/assign @apelisse
APIServer/fieldmanager contains the code that uses smd in Kubernetes.
You need a Parser in order to parse YAML objects into something that you can Apply or Update. It's done by instantiating a FieldManager
, but this requires a bunch of version convertor, defaulter and creator that you can probably fake. There's an example for tests but it's not exported, so you can't re-use it, there's https://github.com/kubernetes/kubernetes/pull/110565 attempting to do just that.
Thanks - I started to give that a go in https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/270 .. it looks pretty good!
Marking as WIP in favor of the approach in #270
@justinsb: PR needs rebase.
Merged the approach in #270 instead - thanks @apelisse :-)
/close
@justinsb: Closed this PR.
Enough to support patch/merge a little better.