search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
254 stars 84 forks source link

Stop using go.mod replace directives #263

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

These make our submodules hard to consume as a library.

go.work is the latest approach that is recommended instead for local development.

I think this does mean we will need to structure commits separately across the libraries, but that may be acceptable.

justinsb commented 1 year ago

/assign @barney-s

barney-s commented 1 year ago

/approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
barney-s commented 1 year ago

/lgtm