search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
254 stars 84 forks source link

Record event when reconciler fails unexpectedly #269

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

Otherwise it's difficult to track down what has gone wrong.

This may lead to over-eventing (if we've already recorded the error), but we can deal with that problem when we come to it!

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
johnsonj commented 1 year ago

Awesome! /lgtm

atoato88 commented 1 year ago

LGTM