Closed justinsb closed 1 year ago
/lgtm Sorry for my delay reviewing.
Oh, this PR needs rebase..
@justinsb Could you rebase?
/LGTM
Two questions and the PR looks great. I'm very looking forward to use this feature in my operator!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: justinsb, yuwenma
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
/retest
/retest
Going to roll the dice one more time, because I think this is the uncertain ordering between watch & apply, so we're closer to fixing it if this goes in, but if that is true I would expect the tests to pass about half the time.
For watch/update conflict, would it help if we bump the test manager's cancelling period https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/272/files#diff-62091d2b32c6b6c94aaed7ea3055732f56d47b34c5f66f31079a61a3908c3689R141 , assuming the probability of happening a second status update (after watch) increases?
/retest
/lgtm
We pass in a function to query the current state of objects, this allows us to cache the results (if using SSA) and allows for cluster targeting.