Prune whitelist

[stephanhorsthemke]

What this PR does / why we need it: This PR fixes some odds and ends to make Pruning + Allowlisting CRDs for pruning work. We need it to use pruning in our custom controller.

Which issue(s) this PR fixes:

This actually fixes the --prune-whitelist part of #201

Special notes for your reviewer: I put some comments in the diff. I believe it would be nice for us already to make CascadingStrategy configurable. I hardcoded it to Foreground here but we don't know yet what behaviour we wanna have.

Additional documentation:

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: stephanhorsthemke / name: stean (2438203c63c8596361a6fa84ff68a2bea25a9899, d28ea937613e2f966139733322d5d2273ca577d3, a148dcf7170eb4e07aa353106c0283b2139442cb)

[k8s-ci-robot]

Hi @stephanhorsthemke. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[k8s-ci-robot]

Welcome @stephanhorsthemke!

It looks like this is your first PR to kubernetes-sigs/kubebuilder-declarative-pattern 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder-declarative-pattern has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[stephanhorsthemke]

Thanks for the review already @justinsb ! I found that it was not working. So the applier test did but when I used it in a controller still nothing happened. Did not run prune at all. I believe I found the two problems which I just fixed in the last commit. Will try again running it now and then look at whether I can tackle your improvement :)

[justinsb]

A few thoughts but LGTM - thanks for the contribution @stephanhorsthemke

/approve /lgtm

[justinsb]

Looks like you need to run goimports (or gofmt) on a few files:

Error: goimports should be run on these files:
pkg/patterns/declarative/pkg/applier/direct.go
pkg/patterns/declarative/pkg/applier/direct_test.go
pkg/patterns/declarative/pkg/applier/type.go
pkg/patterns/declarative/reconciler.go

[justinsb]

/ok-to-test

(I'm assuming that's why the prow tests aren't running?)

[justinsb]

Passing tests - thanks for this @stephanhorsthemke

/approve /lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, stephanhorsthemke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment