search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
254 stars 84 forks source link

Change ApplierOptions to take Objects, not a manifest. #275

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

In theory a breaking change, but should not break anyone and avoids reparsing and confusion over JSON vs YAML input formats.

This fixes a bug in the new applyset applier where we were expecting YAML but getting JSON. That applier is not the default and is only on the dev/main branch, so no backports needed, thankfully!

barney-s commented 1 year ago

/approve /lgtm

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment