search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
254 stars 84 forks source link

Set Overwrite in ApplyOptions #281

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

We lost the default value in #247, which is a regression that prevents some changes from going through.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, tomasaschan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
justinsb commented 1 year ago

@tomasaschan I think it should count if you put /lgtm on its own line :-) It should work for any kubernetes org member. If you're not yet a kubernetes org member, we should do something about that :-)

tomasaschan commented 1 year ago

/lgtm

k8s-ci-robot commented 1 year ago

@tomasaschan: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/281#issuecomment-1322380855): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tomasaschan commented 1 year ago

@justinsb Looks like the ball's in your court 😏

johnsonj commented 1 year ago

/lgtm