Closed justinsb closed 1 year ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: justinsb
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@justinsb: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-declarative-test | 018e23812dd3a185e3877a66e0c20804064e037e | link | true | /test pull-declarative-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Actually looks like we don't have to tackle this just yet, it's just the version on my machine that has updated. So need to update the kubectl version used to generate the golden output.
/close
@justinsb: Closed this PR.
We get the kubectl version from our runner pod, and it has been updated to a newer version that sends a new Accept header.
Update the golden output to expect that.
We probably should run with a known version of kubectl (or skip the test if the version is not correct), but first step is at least to match what we have.