search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
254 stars 84 forks source link

tests: run with a known version of kubectl #289

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

Update hack/ci/test.sh to download kubectl and add it to the path.

Add dev/update-golden to generate golden output with the kubectl version.

We run with kubectl 1.26 so that we get the fast-discovery, as this is expected to roll out more generally over the next few months.

justinsb commented 1 year ago

Getting this to pass reliably probably depends on #287

barney-s commented 1 year ago

/approve /lgtm

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment