search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
254 stars 84 forks source link

Update README about required go version #290

Closed CatherineF-dev closed 1 year ago

CatherineF-dev commented 1 year ago

What this PR does / why we need it:

2023/01/04 15:52:14 failed to initialize project: unable to run pre-scaffold tasks of "base.go.kubebuilder.io/v3": go version 'go1.17' is incompatible because 'requires 1.13 <= version < 1.17'. You can skip this check using the --skip-go-version-check flag

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation:

justinsb commented 1 year ago

Thank you - ideally we would be compatible with later versions of go, but maybe #291 will fix that. I agree with documenting it in the meantime.

Test failure looks unrelated (and I think we have an open PR for it as well, I think it's #289): /retest

justinsb commented 1 year ago

/retest

justinsb commented 1 year ago

Thank you @CatherineF-dev

/approve /lgtm

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CatherineF-dev, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment