kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
254 stars 84 forks source link

Replace mock clients with mock kubeapiserver #294

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

The mock clients are hard to version with changes in controller-runtime, and we have better coverage with our mock kubeapiserver now.

justinsb commented 1 year ago

/assign @barney-s

atoato88 commented 1 year ago

It's LGTM :+1:

yuwenma commented 1 year ago

/lgtm

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment