kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
254 stars 84 forks source link

Cherry pick of #212: Introduce setters for name and namespace #296

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

Cherry pick of #212 on release-0.11

212:Introduce setters for name and namespace

Edited to remove release notes for future release and to continue to expose underlying variables (for compatability).

justinsb commented 1 year ago

/assign @barney-s

I think if we're going to maintain older branches (which I think we can/should), then we need PRs like this which avoid too much reworking of other cherry picks.

Also I have a nice (IMO) script/tool that I'm working on for these that I can share with you :-)

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/release-0.11/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yuwenma commented 1 year ago

As kubebuilder-declarative-pattern usres, I'm looking forward to these Setter methods.

justinsb commented 1 year ago

Thanks @yuwenma - you should be able to say /lgtm for the robots to auto-merge the PR

yuwenma commented 1 year ago

/lgtm