search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
254 stars 84 forks source link

make kustomize hydration a no-op #297

Closed yuwenma closed 1 year ago

yuwenma commented 1 year ago

This PR is aimed at downgrade the kustomize usage in k-d-p, which itself can potentially cause issues on imports and for other feature extension.

TODO: We'd like to use a build constraint to not deprecate methods. I'll work on that later once I get time.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuwenma Once this PR has been reviewed and has the lgtm label, please assign johnsonj for approval by writing /assign @johnsonj in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yuwenma commented 1 year ago

cc @justinsb

yuwenma commented 1 year ago

Close this issue because I made a better approach in https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/299 (go build constraint). Many thanks to @justinsb for the suggestion!