Closed yuwenma closed 1 year ago
/assign @justinsb
Thanks @yuwenma!
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: justinsb, yuwenma
The full list of commands accepted by this bot can be found here.
The pull request process is described here
LGTM :smile:
Should we add documentation about without_kustomize
tag?
@atoato88 that's a good idea. I updated the doc here https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/301 Please let me know if there's anywhere else I shall update.
Problems:
kustomize/api
. This library itself is commonly used by other libraries and users can encounter dependency conflicts if the other library uses a differentkustomize/api
release (what happened on my side and I cannot bump the other kustomize/api version).Description:
This PR split the kustomize hydration to 1. a generic kustomize build and 2. a no-op in different files; It adds a go build constraint
without_kustomize
to give users the ability to switch to opt out the kustomize feature in build time and no need to change their source code.Test: This PR is tested using the guestbook example by changing the
make run
for the following two casesoutput
output
UPDATED