search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
252 stars 84 forks source link

housekeeping: update internal module references #307

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

We want to pick up the latest fixes to mockkubeapiserver.

We regenerate the test data also, we now have more API types.

Also we add more normalization around discovery requests, we try to reorder adjacent requests into alphabetical order, now that we are doing more of them this is more important for golden tests to be the same.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
justinsb commented 1 year ago

/hold while I figure out how the read was avoided - probably the watch, but TBD!

justinsb commented 1 year ago

/retest

justinsb commented 1 year ago

/hold cancel

Changes look pretty good now, just more resources.

Will probably still be flaky until the next PR goes in (starting watches before apply)

/retest

justinsb commented 1 year ago

/retest

Took 4 tries previously, this is number 2

justinsb commented 1 year ago

/retest

justinsb commented 1 year ago

/retest

justinsb commented 1 year ago

/retest

k8s-ci-robot commented 1 year ago

@justinsb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-declarative-test a7e9f8cc38bcf51789135b45c1925326b629c0be link true /test pull-declarative-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
justinsb commented 1 year ago

This was done as part of the hooks PR, which got the tests (hopefully) into a deterministic state, so fewer flakes :crossed_fingers:

/close

k8s-ci-robot commented 1 year ago

@justinsb: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/307#issuecomment-1453655011): >This was done as part of the hooks PR, which got the tests (hopefully) into a deterministic state, so fewer flakes :crossed_fingers: > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.