search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
252 stars 84 forks source link

mockkubeapiserver: Always send content-length #311

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

This allows for more predictable output, as otherwise the length is only sometimes sent (maybe varying by go version)

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yuwenma commented 1 year ago

/lgtm

atoato88 commented 1 year ago

I know that this PR already has lgtm label and be merged, but it looks good from me too.

justinsb commented 1 year ago

Thank you @yuwenma and @atoato88 :-)

Trying to get these tests to pass reliably - I think i know what the problem is - I think we should be setting up the watches before even starting the apply, so I'm working towards that!