search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
252 stars 84 forks source link

Sort APIResources into a consistent order #312

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

Should ensure more predictable test results.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
justinsb commented 1 year ago

/retest

I think these tests are going to be flaky till we get the watches in BeforeApply (https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/277#issuecomment-1451330431)

yuwenma commented 1 year ago

/lgtm

justinsb commented 1 year ago

/retest

justinsb commented 1 year ago

/retest

justinsb commented 1 year ago

Sigh, this is the flake we're trying to fix...

/retest

justinsb commented 1 year ago

Hooray - fourth time's the charm :joy: