search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
252 stars 84 forks source link

Simplify List flattening logic #316

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

Refactor to ensure that we build and flatten the objects in one place, simplifying execution. The intermediate call to VersionCheck (should) prefer flattened objects.

atoato88 commented 1 year ago

/retest

atoato88 commented 1 year ago

The test result seems flaky one? :thinking:

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
atoato88 commented 1 year ago

/retest

atoato88 commented 1 year ago

/lgtm