search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
256 stars 85 forks source link

Replace k8s.gcr.io with registry.k8s.io #317

Closed xmudrii closed 1 year ago

xmudrii commented 1 year ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR replaces all k8s.gcr.io references with registry.k8s.io. See the linked issue for more details.

Which issue(s) this PR fixes: xref https://github.com/kubernetes/k8s.io/issues/4738

Release note:

Replace all `k8s.gcr.io` references with `registry.k8s.io`
justinsb commented 1 year ago

/retest

Looks like our tests aren't 100% deterministic yet...

atoato88 commented 1 year ago

/retest

umm? is it flaky?

atoato88 commented 1 year ago

/lgtm /approve

We got success.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [atoato88] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
justinsb commented 1 year ago

Yes, looks like we still have some non-determinism here. I think it might be that we need to make sure that mockkubeapiserver marks things healthy now that we are checking health more carefully. I'll take a look!