search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
252 stars 84 forks source link

Run CI with go workspace #321

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

Because of the challenges of updating multiple modules at the same time, we run our tests with a go workspace, so that we test with all the latest code.

Maybe we should commit a go workspace to the repo, but conventional advice (I believe) is not to do that.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation:

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yuwenma commented 1 year ago

/lgtm

Considering that we have several PRs that improve the main k-d-p e2e test but the change is in the dependencies (applier and mock-kubeapiserver), making this CI change can greatly improve and expedite the developing cycle.

yuwenma commented 1 year ago

Seems like the PRs are blocking each other (maybe merging https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/320 into this one? or merge with CI failure)

k8s-ci-robot commented 1 year ago

@justinsb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-declarative-test b8abeb9c199b204c8bef3bee252002451cf30af5 link true /test pull-declarative-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yuwenma commented 1 year ago

/lgtm

justinsb commented 1 year ago

Done as part of #320 (had to merge both to get good test signal)

/close

k8s-ci-robot commented 1 year ago

@justinsb: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/321#issuecomment-1481990080): >Done as part of #320 (had to merge both to get good test signal) > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.