search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
252 stars 84 forks source link

Bump Golang 1.20 and controller-runtime v0.15.0-alpha.0 #333

Closed camilamacedo86 closed 1 year ago

camilamacedo86 commented 1 year ago

What would you like to be added:

Why is this needed:

stephanhorsthemke commented 1 year ago

Hey! I am somewhat blocked by this as I needed to upgrade some downstream dependencies to controller-runtime@v0.15.0-alpha.0 in order to work around some other dependency issues.

Here's what happens when running declarative pattern with that version atm.

$ go vet ./...                                                                                                                 
# sigs.k8s.io/kubebuilder-declarative-pattern/pkg/test/mocks
../../../go/pkg/mod/sigs.k8s.io/kubebuilder-declarative-pattern@v0.13.0-beta.1.0.20230113160225-18dbaf5fcd85/pkg/test/mocks/manager.go:48:25: cannot use &Manager{} (value of type *Manager) as manager.Manager value in variable declaration: *Manager does not implement manager.Manager (wrong type for method GetControllerOptions)
                have GetControllerOptions() "sigs.k8s.io/controller-runtime/pkg/config/v1alpha1".ControllerConfigurationSpec
                want GetControllerOptions() "sigs.k8s.io/controller-runtime/pkg/config".Controller
# sigs.k8s.io/kubebuilder-declarative-pattern/pkg/patterns/declarative
../../../go/pkg/mod/sigs.k8s.io/kubebuilder-declarative-pattern@v0.13.0-beta.1.0.20230113160225-18dbaf5fcd85/pkg/patterns/declarative/metrics.go:354:20: undefined: source.NewKindWithCache
../../../go/pkg/mod/sigs.k8s.io/kubebuilder-declarative-pattern@v0.13.0-beta.1.0.20230113160225-18dbaf5fcd85/pkg/patterns/declarative/metrics.go:356:22: cannot use recordTrigger{…} (value of type recordTrigger) as handler.EventHandler value in assignment: recordTrigger does not implement handler.EventHandler (wrong type for method Create)
                have Create("sigs.k8s.io/controller-runtime/pkg/event".CreateEvent, workqueue.RateLimitingInterface)
                want Create(context.Context, "sigs.k8s.io/controller-runtime/pkg/event".CreateEvent, workqueue.RateLimitingInterface)
../../../go/pkg/mod/sigs.k8s.io/kubebuilder-declarative-pattern@v0.13.0-beta.1.0.20230113160225-18dbaf5fcd85/pkg/patterns/declarative/metrics.go:534:30: cannot use recordTrigger{} (value of type recordTrigger) as handler.EventHandler value in variable declaration: recordTrigger does not implement handler.EventHandler (wrong type for method Create)
                have Create("sigs.k8s.io/controller-runtime/pkg/event".CreateEvent, workqueue.RateLimitingInterface)
                want Create(context.Context, "sigs.k8s.io/controller-runtime/pkg/event".CreateEvent, workqueue.RateLimitingInterface)
../../../go/pkg/mod/sigs.k8s.io/kubebuilder-declarative-pattern@v0.13.0-beta.1.0.20230113160225-18dbaf5fcd85/pkg/patterns/declarative/watch.go:103:45: not enough arguments in call to apiutil.NewDiscoveryRESTMapper
        have (*rest.Config)
        want (*rest.Config, *http.Client)
../../../go/pkg/mod/sigs.k8s.io/kubebuilder-declarative-pattern@v0.13.0-beta.1.0.20230113160225-18dbaf5fcd85/pkg/patterns/declarative/watch.go:124:6: src.InjectStopChannel undefined (type *source.Channel has no field or method InjectStopChannel)
camilamacedo86 commented 1 year ago

It is done. So I am closing this issue

atoato88 commented 1 year ago

Thank you for closing this, I forgot that..