search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
252 stars 84 forks source link

bump controller-runtime #335

Closed stephanhorsthemke closed 1 year ago

stephanhorsthemke commented 1 year ago

What this PR does / why we need it: Bumps controller-runtime and fixes breaking changes

Which issue(s) this PR fixes:

Fixes https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/issues/333.

Special notes for your reviewer: This PR already unblocks me as I'll just point the go mod to this commit. I don't have much familiarity with the changes and we should maybe put some more thoughts into some of the changes.

Locally I had some test failures also on master and they looked similar

Additional documentation:

k8s-ci-robot commented 1 year ago

Hi @stephanhorsthemke. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
atoato88 commented 1 year ago

/ok-to-test

atoato88 commented 1 year ago

/assign @justinsb Could you review this? And CI test failed, is this flaky one?

atoato88 commented 1 year ago

@justinsb

I checked the result on prow job. And I created the update on forked my repo to pass the job. Using this update, hack/ci/test.sh passed with success on my laptop.

But I wonder if my update is valid, because I updated the expected data.

stephanhorsthemke commented 1 year ago

Hey all and thanks for the swift reviews! I unblocked myself with this branch already and have trouble to prioritise this now. @atoato88 or anybody else, Please just feel free and take this over. Your changes look good. Maybe we could merge this into another branch in the upstream repo so you have all the permissions?

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stephanhorsthemke Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
stephanhorsthemke commented 1 year ago

Alright. I just went ahead and at least did what @atoato88 did in his branch to see if that fixes all the tests!

What I can't answer is if it is alright and fine that the expected client is different now!

atoato88 commented 1 year ago

Umm, test result was not success, I will update my commit.

atoato88 commented 1 year ago

I created the update. Could you merge this?

kkkkun commented 1 year ago

I created the update. Could you merge this?

@camilamacedo86 @stephanhorsthemke the update is usefully to pull-declarative-test. Should we update and merge ？

It's block https://github.com/kubernetes-sigs/kubebuilder/pull/3421

atoato88 commented 1 year ago

@justinsb Gentle ping. Could you review this?

kkkkun commented 1 year ago

Thanks for you PR. If you have no time, I will open PR https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/337 which contain your commit informations. If you want to start agains. I would close https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/337.

k8s-ci-robot commented 1 year ago

@stephanhorsthemke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-declarative-test 945f0f573142ce39e32aad789a03bcc19271b779 link true /test pull-declarative-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
stephanhorsthemke commented 1 year ago

Amazing @kkkkun Thanks for taking over. I haven't had the time to follow up on this until now so that's great! I'll close this PR.