kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
252 stars 84 forks source link

Bump controller runtime to v0.15.0 #337

Closed kkkkun closed 1 year ago

kkkkun commented 1 year ago

xref https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/335

Upgrade controller-runtime to v0.15.0, which is block https://github.com/kubernetes-sigs/kubebuilder/pull/3421

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/issues/333

Special notes for your reviewer:

Additional documentation:

k8s-ci-robot commented 1 year ago

Welcome @kkkkun!

It looks like this is your first PR to kubernetes-sigs/kubebuilder-declarative-pattern 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder-declarative-pattern has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 year ago

Hi @kkkkun. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
atoato88 commented 1 year ago

/ok-to-test I added a label to test. By this, we can check the result by prow on this PR.

kkkkun commented 1 year ago

I left a comment.

The tests passed. Thanks.

atoato88 commented 1 year ago

I have informed @justinsb on #335 , but I would like to confirm with him regarding the validity of this revision. I apologize for repeating my statement.

kkkkun commented 1 year ago

We need this PR for kubebuider. Could you please review this @stephanhorsthemke @camilamacedo86

atoato88 commented 1 year ago

/lgtm

There have been no changes for about 1 week. We need to move forward to release kubebuilder.

/assign @justinsb Gentle ping. Could you review this PR?

atoato88 commented 1 year ago

/approve I acknowledge that we have not made progress, but we need to move forward.

@justinsb I apologize for approving this PR without your comments. Please feel free to comment if you have any.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, kkkkun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [atoato88] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kkkkun commented 1 year ago

We need a tag.

atoato88 commented 1 year ago

@justinsb Could you add a tag against the current content?

kkkkun commented 1 year ago

@justinsb Could you add a tag against the current content? Actually it's not need tag. It's used commit id. https://github.com/kubernetes-sigs/kubebuilder/pull/3421/commits/d5ff1ae4153a89f162458d0a6552fbfe37b679a1