search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
252 stars 84 forks source link

Fix github workflows #339

Closed atoato88 closed 1 year ago

atoato88 commented 1 year ago

What this PR does / why we need it:

This PR fixes the problem with github workflows, and update go-version with 1.20 on workflows.

Which issue(s) this PR fixes: NONE

Special notes for your reviewer: NONE

Additional documentation: NONE

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [atoato88] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
atoato88 commented 1 year ago

Following is the sample error on github before merging this PR: https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/actions/runs/5171521822

By this PR, github workflow error will be fixed: https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/actions/runs/5318352072

atoato88 commented 1 year ago

/assign @justinsb Could you review this?

k8s-ci-robot commented 1 year ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
atoato88 commented 1 year ago

/close

This problem is fixed by #341, so I close this PR. Thank you for @yuwenma :+1:

k8s-ci-robot commented 1 year ago

@atoato88: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/339#issuecomment-1606354920): >/close > >This problem is fixed by #341, so I close this PR. >Thank you for @yuwenma :+1: Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.