kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
252 stars 84 forks source link

Create abstraction layer over controller-runtime/client-go versions #342

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

Create an abstraction layer so that we are less dependent on a particular version of client-go / controller-runtime. The intent here is that controllers can work with multiple versions of client-go/controller-runtime, and thus a wide range of k8s versions.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
justinsb commented 1 year ago

/wip

yuwenma commented 1 year ago

Thank you so much for adding this abstraction layer. LGTM (looks like the test caught some additional cases need to fix).

yuwenma commented 1 year ago

/lgtm