search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
252 stars 84 forks source link

Bump controller-runtime to v0.15.2 #349

Closed rayandas closed 10 months ago

rayandas commented 10 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation:

camilamacedo86 commented 10 months ago

HI @rayandas,

Thank you for looking on that. It is not passing in the tests. By looking them: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kubebuilder-declarative-pattern/349/pull-declarative-test/1696632514203881472 I believe that if you just remove the indirect deps : https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kubebuilder-declarative-pattern/349/pull-declarative-test/1696632514203881472 and re-run go mod tidy it might be sorted out.

justinsb commented 10 months ago

This PR bumps controller-runtime from 0.15.0 to 0.15.2 . I updated the title to reflect that, and now that it is passing tests...

/approve /lgtm

Thanks @rayandas

k8s-ci-robot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, rayandas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment