search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
251 stars 84 forks source link

Play nicely with third-party testing libraries #353

Closed tomasaschan closed 8 months ago

tomasaschan commented 9 months ago

What this PR does / why we need it:

This makes the validator use an interface compatible with *testing.T instead of using *testing.T directly, in order to allow third-party testing libraries to provide an equivalent implementation instead of the built-in one.

See e.g. https://onsi.github.io/ginkgo/#using-third-party-libraries for a use case of this setup.

k8s-ci-robot commented 9 months ago

Hi @tomasaschan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tomasaschan commented 9 months ago

Ping @justinsb :)

atoato88 commented 9 months ago

/ok-to-test

atoato88 commented 9 months ago

/lgtm It looks good, and pased the test.

tomasaschan commented 9 months ago

Ping! Could someone please /approve this? Would be nice to get it into master so we can use this in our operator test suites.

atoato88 commented 8 months ago

/approve

k8s-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, tomasaschan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [atoato88] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment