Closed ChristopherFry closed 8 months ago
Hi @ChristopherFry. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/cc @justinsb
Thanks @ChristopherFry!
This reminds me of an idea that we've had but never written down, IIRC: we should log a warning when users use things/don't use things we recommend. Here it's pretty clear-cut and gives an obvious error, but it would still be better if that warning happened earlier. With an env-var, we could even switch it between warning or fatal or silent, corresponding to development vs production.
In any case...
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ChristopherFry, justinsb
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This pull request removes the client-side apply validation from the example guestbook operator allowing the operator to successfully reconcile changes.
Previously the operator would show this error when reconciling:
This error is due to client-side validation being deprecated in the direct applier with #352.