search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
257 stars 85 forks source link

chore: allow tools to be installed with newer versions of go #358

Closed ChristopherFry closed 1 year ago

ChristopherFry commented 1 year ago

This change fixes the example guestbook operator Makefile by allowing the controller-gen and kustomize tools to be successfully installed.

Previously any Make commands requiring one of these tools such as make generate would fail since the go-get-tool function would only download the package with go get however not install the package with go install, where go get no longer installs executables since Go 1.17, https://go.dev/doc/go-get-install-deprecation.

The updated Makefile commands for controller-gen and kustomize aligns with the Makefile kubebuilder generates for new projects, https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v3/Makefile.

k8s-ci-robot commented 1 year ago

Hi @ChristopherFry. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
justinsb commented 1 year ago

Thanks @ChristopherFry . I've started using go run everywhere rather than trying to install things, there used to be a big performance penalty but I think that penalty is now negligible.

But this simplifies the build scripts, so...

/approve /lgtm

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChristopherFry, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment