Validator inserts extra newlines between Objects

[annasong20]

What happened:

Validator expects empty lines before and after each document separator --- in the expected output manifests that I specify in "*.out.yaml".

#example.out.yaml
apiVersion: v1
kind: Namespace
metadata:
  name: x

---

apiVersion: v1
kind: Namespace
metadata:
  name: y

What you expected to happen:

I expected that I should be able to specify consecutive objects in my "*.out.yaml" file without the extra newlines.

#example.out.yaml
apiVersion: v1
kind: Namespace
metadata:
  name: x
---
apiVersion: v1
kind: Namespace
metadata:
  name: y

How to reproduce it (as minimally and precisely as possible):

You can see that the existing guestbook test with validator

• https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/f6a5c89244f2221088444042166f89743d409515/examples/guestbook-operator/controllers/guestbook_controller_test.go#L27

expects newlines before and after each document separator https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/f6a5c89244f2221088444042166f89743d409515/examples/guestbook-operator/controllers/tests/patches-stable.out.yaml#L32

Anything else we need to know?:

This line

• https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/f6a5c89244f2221088444042166f89743d409515/pkg/test/golden/validator.go#L324

that adds additional newlines, even though yamilzer.Encode already adds a newline after the object, is likely the culprit.