search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
251 stars 84 forks source link

Fix Validator output spacing #360 #361

Closed annasong20 closed 7 months ago

annasong20 commented 7 months ago

Fixes #360 by removing extra newlines between objects in test/validator manifest output.

What this PR does / why we need it: Which issue(s) this PR fixes:

Fixes #360.

annasong20 commented 7 months ago

/cc @yuwenma @haiyanmeng

justinsb commented 7 months ago

Thanks @annasong20

/approve /lgtm

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annasong20, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
atoato88 commented 7 months ago

Nice catch! Thank you for posting PR!