search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
257 stars 85 forks source link

Cherry-pick #361 and master flake fixes to release-0.13 #362

Closed annasong20 closed 11 months ago

annasong20 commented 11 months ago

What this PR does / why we need it:

This PR cherry-picks #361 to the release-0.13 branch. Because the current release-0.13 branch doesn't have the commits that fix the flaky tests, this PR also cherry-picks all commits up to https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/commit/8f5c459345f20404734bcd78eecc35cdfcbd86f7.

This PR allows users to consume #361 in environments that cannot update their sigs.k8s.io/controller-runtime version past v0.15.0.

Additional information

I didn't create this PR against release-0.15 branch because the tip of that branch is on v0.15.2 of sigs.k8s.io/controller-runtime, which my environment cannot update to yet.

k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: annasong20 Once this PR has been reviewed and has the lgtm label, please assign atoato88 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/release-0.13/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yuwenma commented 11 months ago

/lgtm

Thank you, Anna.

annasong20 commented 11 months ago

/cc @haiyanmeng

annasong20 commented 11 months ago

/close

After discussion with @yuwenma, @justinsb, we've decided to close this PR in favor of adding

//go:build

comments to make the master branch backwards compatible with previous versions of controller-runtime.

k8s-ci-robot commented 11 months ago

@annasong20: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/362#issuecomment-1833981176): >/close > >After discussion with @yuwenma, @justinsb, we've decided to close this PR in favor of adding > >``` >//go:build >``` > >comments to make the master branch backwards compatible with previous versions of controller-runtime. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.