search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
251 stars 84 forks source link

Mocks don't match current controller-runtime package #363

Open steeling opened 7 months ago

steeling commented 7 months ago

What happened:

pkg/test/mocks/manager.go isn't up to date with the controller-runtime package marked in go.mod

What you expected to happen:

pkg/test/mocks/manager.go.Manager should implement the controller-runtime Manager interface that it is supposed to mock.

How to reproduce it (as minimally and precisely as possible):

Attempt to use NewValidator

Anything else we need to know?:

var _ manager.Manager = &Manager{} line 48 in pkg/test/mocks/manager.go doesn't compile

Environment:

steeling commented 7 months ago

Looks like there's no linting or unit tests being run as a PR presubmit, aside from some KIND installation? https://github.com/steeling/kubebuilder-declarative-pattern/blob/master/.github/workflows/main.yml

tomasaschan commented 4 months ago

@justinsb This is (at least part of) the problem I mentioned in controller-runtime compat.

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 week ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten