Closed annasong20 closed 11 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/cc @yuwenma @haiyanmeng
/lgtm
Thanks @annasong20 - this is nice!
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: annasong20, justinsb
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it:
This PR makes the code backwards-compatible with versions of controller-runtime before 0.16, which introduced the metrics/server package that kdp now uses. The PR uses
//go:build
to segregate handling of the metrics configuration depending on the version of controller-runtime.Special notes for your reviewer:
N/A
Additional documentation:
The following links may be useful references
//go:build
usage: https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/342