search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
251 stars 84 forks source link

Extract GVK more robustly when building applyset parent #368

Closed justinsb closed 5 months ago

justinsb commented 6 months ago

Include the case when we're using a typed object.

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maqiuyujoyce commented 6 months ago

Thank you so much for the quick fix, @justinsb ! I made a local copy of your change and verified the issue in the CC reconciliation is fixed.

/lgtm

k8s-ci-robot commented 6 months ago

@maqiuyujoyce: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/368#issuecomment-1882091020): >Thank you so much for the quick fix, @justinsb ! I made a local copy of your change and verified the issue in the CC reconciliation is fixed. > >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cheftako commented 5 months ago

/lgtm