search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
256 stars 85 forks source link

Bump k8s.io/kubectl to 0.29.1 #379

Closed tomasaschan closed 6 months ago

tomasaschan commented 7 months ago

Main motivation is to include https://github.com/kubernetes/kubernetes/pull/122346

I don't know if there's a way to do this that touches fewer dependencies; I tried a bunch of ways with go get [-u] k8s.io/kubectl[@0.29.1] but all of them resulted in this full set of changes.

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tomasaschan Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 7 months ago

Hi @tomasaschan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
atoato88 commented 7 months ago

/ok-to-test

tomasaschan commented 7 months ago

@justinsb This is currently blocking us from bumping k8s.io/kubectl to 0.29.1 and get this fix. Any chance you can review this soon-ish? :)

atoato88 commented 7 months ago

/assign @justinsb Could you review this?

atoato88 commented 7 months ago

@justinsb Gentle ping, cloud you review this?

k8s-ci-robot commented 6 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
atoato88 commented 6 months ago

@tomasaschan @justinsb Can we close this PR w/o merging, because #380 is merged? That PR had the update bumping kubectl to v0.29.1.