search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
251 stars 84 forks source link

Bump controller-runtime to 0.17 / kube to 1.29 #380

Closed justinsb closed 3 months ago

justinsb commented 4 months ago
k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tomasaschan commented 4 months ago

Let me know if I can help speed this along somehow!

atoato88 commented 4 months ago

This PR is related with the content of #379. I think #379 can be closed if this PR is merged.

atoato88 commented 4 months ago

@justinsb Ping, how about the current state of this?

justinsb commented 3 months ago

Removed WIP, and I also think we should consider expanding ownership of this repo, perhaps starting with @tomasaschan . Sometimes I get pulled into different things and things fall off my plate - sorry for the delays here!

tomasaschan commented 3 months ago

/lgtm

(but I suspect it won't matter yet...)

k8s-ci-robot commented 3 months ago

@tomasaschan: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/380#issuecomment-2003835759): >/lgtm > >(but I suspect it won't matter yet...) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
atoato88 commented 3 months ago

/lgtm

atoato88 commented 3 months ago

I agree with expanding ownership. 👍