Closed justinsb closed 6 months ago
/hold for input from tomasaschan
@tomasaschan would like to be a reviewer? (With a view to getting ownership in time, but we're not supposed to start you as an owner) I think you have demonstrated a deep understanding of the code and an ability to contribute.
cc @atoato88 and @johnsonj - do you agree with this suggestion?
I'd be happy to!
/lgtm
Just to formally indicate this (even though it won't work until this is merged, IIUC).
@tomasaschan: changing LGTM is restricted to collaborators
/lgtm
@johnsonj: changing LGTM is restricted to collaborators
changing LGTM is restricted to collaborators
Well that's not good, either prow is having a moment or maybe we've change the config (so that approvers can't LGTM?)... I'll try to figure out what's going on here
/lgtm
User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
@tomasaschan is not member of org member? Could you reat the document here for becoming the member of that.
Hum. I think I have everything in place except two sponsors from different companies. @atoato88 @justinsb OK if I name the two of you as my sponsors? (I can't tell from your GH profile if you're also a Googler, @atoato88 ...)
I can become your sponsor! I know your activities on this repo and I am not a googler. :smile:
Thank you for mentioning me, I commented on https://github.com/kubernetes/org/issues/4837
Thank you! Then I think we just need a +1 from Justin there too, which I suppose will have to wait until I after kubecon :)
I've now been added as a member of the org, so this should be unblocked!
/hold cancel
(probably won't work)
/verify-owners
Thank you for catching up this PR and I'm very appreciate that you joined this repo! :smile:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: justinsb
The full list of commands accepted by this bot can be found here.
The pull request process is described here