kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
256 stars 85 forks source link

owners: add tomasaschan to reviewers #381

Closed justinsb closed 6 months ago

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
justinsb commented 6 months ago

/hold for input from tomasaschan

@tomasaschan would like to be a reviewer? (With a view to getting ownership in time, but we're not supposed to start you as an owner) I think you have demonstrated a deep understanding of the code and an ability to contribute.

cc @atoato88 and @johnsonj - do you agree with this suggestion?

tomasaschan commented 6 months ago

I'd be happy to!

tomasaschan commented 6 months ago

/lgtm

Just to formally indicate this (even though it won't work until this is merged, IIUC).

k8s-ci-robot commented 6 months ago

@tomasaschan: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/381#issuecomment-2003884535): >/lgtm > >Just to formally indicate this (even though it won't work until this is merged, IIUC). Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
johnsonj commented 6 months ago

/lgtm

k8s-ci-robot commented 6 months ago

@johnsonj: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/381#issuecomment-2004065630): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
justinsb commented 6 months ago

changing LGTM is restricted to collaborators

Well that's not good, either prow is having a moment or maybe we've change the config (so that approvers can't LGTM?)... I'll try to figure out what's going on here

atoato88 commented 6 months ago

/lgtm

atoato88 commented 6 months ago

k8s-ci-bot said:

User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

@tomasaschan is not member of org member? Could you reat the document here for becoming the member of that.

tomasaschan commented 6 months ago

Hum. I think I have everything in place except two sponsors from different companies. @atoato88 @justinsb OK if I name the two of you as my sponsors? (I can't tell from your GH profile if you're also a Googler, @atoato88 ...)

tomasaschan commented 6 months ago

https://github.com/kubernetes/org/issues/4837

atoato88 commented 6 months ago

I can become your sponsor! I know your activities on this repo and I am not a googler. :smile:

atoato88 commented 6 months ago

Thank you for mentioning me, I commented on https://github.com/kubernetes/org/issues/4837

tomasaschan commented 6 months ago

Thank you! Then I think we just need a +1 from Justin there too, which I suppose will have to wait until I after kubecon :)

tomasaschan commented 6 months ago

I've now been added as a member of the org, so this should be unblocked!

/hold cancel

(probably won't work)

tomasaschan commented 6 months ago

/verify-owners

atoato88 commented 5 months ago

Thank you for catching up this PR and I'm very appreciate that you joined this repo! :smile: