Closed haiyanmeng closed 5 months ago
Hi @haiyanmeng. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
Thank you @haiyanmeng
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: haiyanmeng, justinsb, tomasaschan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
https://book.kubebuilder.io/reference/markers/crd-processing
Currently, a MOSS controller does not support patches correctly by default. For example, applying the following object would get an error
strict decoding error: unknown field "spec.patches[0].apiVersion", unknown field "spec.patches[0].kind", unknown field "spec.patches[0].metadata", unknown field "spec.patches[0].spec"
.To fix this, we need to add
x-kubernetes-preserve-unknown-fields: true
into thepatches
field of ConfigSync CRD: