search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
251 stars 84 forks source link

Expose more health info as well as counts in Apply results #393

Closed barney-s closed 3 weeks ago

barney-s commented 1 month ago

What this PR does / why we need it:

Expose more health info as well as counts in Apply results When using applyset as a library we sometimes want more information about the last applied set. Currently we get boolean (IsHealthy, IsAllApplied). Having more is useful when consuming this as a library.

barney-s commented 1 month ago

/test pull-declarative-test

barney-s commented 1 month ago

/assign @justinsb

justinsb commented 3 weeks ago

Looks great now, thanks @barney-s

/approve /lgtm

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment