search

kubernetes-sigs / kubebuilder-declarative-pattern

A toolkit for building declarative operators with kubebuilder
Apache License 2.0
251 stars 84 forks source link

chore: stage ktest module #400

Open justinsb opened 4 days ago

justinsb commented 4 days ago

This should enable us to add a module much more easily, because go mod tidy will work.

k8s-ci-robot commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
justinsb commented 4 days ago

This is intended to support #383 , which ends up needing a new shared library, but it proves very difficult to add a module and use it in one commit, even with go workspaces. I think creating a stub module (as here) should (1) work around the problem and (2) be a reasonable compromise in terms of breaking up commits.