kubernetes-sigs / kubebuilder-release-tools

Release tooling for KubeBuilder projects.

Apache License 2.0

18 stars 25 forks source link

🐛 Duplicate the check run even if we need to re-run the tests #20

Closed Adirio closed 3 years ago

Adirio commented 3 years ago

17#issuecomment-730275334

Fixes #17

Adirio commented 3 years ago

Requires #23 to get merged first

/hold

DirectXMan12 commented 3 years ago

generally looks fine (although if we choose to re-target on synchronize we might just want to immediately move to sending the results to HEAD, instead of duplicating them at the end), but see my comment on #21 for why we should not include #21

Adirio commented 3 years ago

generally looks fine (although if we choose to re-target on synchronize we might just want to immediately move to sending the results to HEAD, instead of duplicating them at the end)

In most cases, that check will already be done and we will just send the results to HEAD. It computes them back if it can't find the Check Run and thus has to create it. I chose to send them back to the before commit too in order to avoid a hanging unfinished check.

Adirio commented 3 years ago

The dependency on #21 has been replaced by a dependency on #23, which just provides the improved debug output.

Adirio commented 3 years ago

23 merged

/unhold

DirectXMan12 commented 3 years ago

/approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-release-tools/blob/master/OWNERS)~~ [DirectXMan12] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment