kubernetes-sigs / kubebuilder-release-tools

Release tooling for KubeBuilder projects.
Apache License 2.0
18 stars 25 forks source link

✨ Add :rocket: as a valid prefix for release PRs #55

Closed mjlshen closed 1 year ago

mjlshen commented 1 year ago

Fixes #54 by adding :rocket: as a valid emoji prefix

Along the way I adjusted:

panic(fmt.Sprintf("unrecognized PR type %v", t))

to

panic("unrecognized PR type")

because I was getting this (rightful) compiler error when running tests:

fmt.Sprintf format %v with arg t causes recursive (sigs.k8s.io/kubebuilder-release-tools/notes/common.PRType).String method call

mjlshen commented 1 year ago

cc @g-gaston @furkatgofurov7 @vincepri as discussed today

mjlshen commented 1 year ago

/assign @vincepri

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjlshen, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubebuilder-release-tools/blob/master/OWNERS)~~ [vincepri] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mjlshen commented 1 year ago

@vincepri What do you think about a new release with this change so that cluster-api can pin to the new released version?

vincepri commented 1 year ago

done