MIgrate build and promotion of images from Kubebuilder GCP

kubernetes-sigs / kubebuilder-release-tools

Release tooling for KubeBuilder projects.

Apache License 2.0

18 stars 25 forks source link

MIgrate build and promotion of images from Kubebuilder GCP #60

Closed camilamacedo86 closed 3 months ago

camilamacedo86 commented 4 months ago

We are using the project to generate the image gcr.io/kubebuilder/pr-verifier:$TAG_NAME. This image, generated by the project https://github.com/kubernetes-sigs/kubebuilder-release-tools, is used in the CI to verify PR emojis for release notes.

The goal of this one is move forward and use he regular image promotion / k8s infra to promote those images.

Be aware that the current images will be unavailable from March 18, 2025.

Motivation: https://github.com/kubernetes/k8s.io/issues/2647 and https://github.com/kubernetes-sigs/kubebuilder/discussions/3907

camilamacedo86 commented 3 months ago

Following some important info to help out on this one

We might can use the artefacted created already: https://github.com/kubernetes/k8s.io/pull/4586
It will be required add the JOB to build the image in the e2e infra that would be something like: https://github.com/kubernetes/test-infra/pull/29351/files
When an tag is pushed in this repo, we just need to build the image from Dockerfile that is here.

Something like:


docker build \
    -t gcr.io/kubebuilder/pr-verifier:$TAG_NAME \
    -f Dockerfile \

TAM360 commented 3 months ago

@camilamacedo86 I am interested in working on this task.

camilamacedo86 commented 3 months ago

It seems out of the scope but we probably need add more people in : https://github.com/kubernetes/k8s.io/pull/4586/files#r1682542243

(Just adding here for now)

camilamacedo86 commented 3 months ago

@TAM360

Thank you a lot for your terrfic work and help us understand how would be the process moving forward. This project does not do too much today and has no maintainers

Therefore, due the fact of this image only check the PR title it seems that make no sense we need to have the infrastructure for each and have a process where we need to build image in stage and then publish for prod. It seems that we can create a shell script or let people use the same implementation in other ways.

So, lets close this one

@sbueringer ^ +1 for your thought that the work is not valid here.

sbueringer commented 3 months ago

Sounds reasonable to me