scaffolds hub and spoke interfaces for conversion webhooks.

kubernetes-sigs / kubebuilder

Kubebuilder - SDK for building Kubernetes APIs using CRDs

http://book.kubebuilder.io

Apache License 2.0

7.89k stars 1.45k forks source link

scaffolds hub and spoke interfaces for conversion webhooks. #2589

Open camilamacedo86 opened 2 years ago

camilamacedo86 commented 2 years ago

What do you want to happen?

scaffolds hub and spoke interfaces for conversion webhooks. With this change, users can either specify --conversion flag and implement the interface on their own, or specify --hub and --spoke versions which will scaffold the skeleton code for both the interfaces.

Follow up/finish the work which started : https://github.com/kubernetes-sigs/kubebuilder/pull/2084

Extra Labels

No response

NikhilSharmaWe commented 2 years ago

@camilamacedo86 What do we need to do here?

Do we need to:

Open a new PR with the changes done in https://github.com/kubernetes-sigs/kubebuilder/pull/2084
Work on the suggested changes mentioned in the PR review
Rebase the PR

NikhilSharmaWe commented 2 years ago

@camilamacedo86 Could you please take a look at my previous comment.

camilamacedo86 commented 2 years ago

Sure. Please, feel free to work on this one.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

laxmikantbpandhare commented 2 years ago

/assign I can take a look into it.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

camilamacedo86 commented 2 years ago

Yes, the goal of this task is to finalize the implementation done in the https://github.com/kubernetes-sigs/kubebuilder/pull/2084. So, you can get the changes made and address the comments.

IN this way, this one seems a good fit for the good first issue.

26tanishabanik commented 2 years ago

/assign

momom-i commented 2 years ago

@camilamacedo86 Is it already done? If not, I'd like to work on this!

camilamacedo86 commented 2 years ago

Hi @momom-i.

It is not. Please, feel free to work on this one. Your collaboration is very welcome.

I do not think that @26tanishabanik has been work on this. @26tanishabanik if you are doing it please, let us know.

Thx.

ashutosh887 commented 1 year ago

I don't think it's still resolved I would like to work on this now

/assign

momom-i commented 1 year ago

@ashutosh887 I’m working on this now. /assign

ashutosh887 commented 1 year ago

Sure @momom-i Please let me know if you need any help

ashutosh887 commented 1 year ago

Let me work on this @camilamacedo86 if @momom-i is unable to resolve

lauchokyip commented 1 year ago

/assign

momom-i commented 1 year ago

/assign

lauchokyip commented 1 year ago

For anyone who is interested in working on this PR, IMHO, I do not think it's a good-first-issue. It requires good amount of knowledge for Go, cli and Kubernetes Webhook. You would also need to read the design proposals to come up with the best practice. Simply copy and paste the OP's PR will not work.

Estimated time from understanding to coding to open an PR and to get it merged would require at least a month of effort

k8s-triage-robot commented 6 months ago

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

Confirm that this issue is still relevant with /triage accepted (org members only)
Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

camilamacedo86 commented 1 week ago

It was good first issue when the effort was follow up the work done. However, now it is no longer the case. So, this one will be hard for anyone to take. I am working on this.