kubernetes-sigs / kubectl-validate

Apache License 2.0
145 stars 35 forks source link

add apiregistration schema #116

Closed alexzielenski closed 5 months ago

alexzielenski commented 5 months ago

apiregistration.k8s.io schema information was not being published until mid 1.27 release cycle so was not incldued with the rest of the builtins. This commit injects the 1.27 schema into earlier releases, and updates 1.27 schemas to use it.

https://github.com/kubernetes/kubernetes/pull/118879

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #114

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adds missing apiregistration.k8s.io schemas to builtin 1.27 validation and earlier

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexzielenski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubectl-validate/blob/main/OWNERS)~~ [alexzielenski] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
eddycharly commented 5 months ago

/lgtm

eddycharly commented 5 months ago

❤️