search

kubernetes-sigs / kubectl-validate

Apache License 2.0
121 stars 31 forks source link

chore: add windows tests #120

Closed eddycharly closed 2 months ago

eddycharly commented 2 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

eddycharly commented 2 months ago

/label tide/merge-method-squash

eddycharly commented 2 months ago

Really appreciate you doing this!

I think i introduced the bug... I break it, i fix it! =)

eddycharly commented 2 months ago

@alexzielenski tests are green finally :)

alexzielenski commented 2 months ago

/lgtm /approve

eddycharly commented 2 months ago

@alexzielenski Shouldn't tide/merge-method-squash allow merging even with merge commits ?

alexzielenski commented 2 months ago

/lgtm /approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexzielenski, eddycharly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubectl-validate/blob/main/OWNERS)~~ [alexzielenski] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment